Indhumathi27 commented on a change in pull request #3580: [CARBONDATA-3665]
Support TimeBased Cache expiration using Guava Cache
URL: https://github.com/apache/carbondata/pull/3580#discussion_r371613959
##########
File path:
core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java
##########
@@ -43,10 +45,11 @@
private static final Logger LOGGER =
LogServiceFactory.getLogService(CarbonLRUCache.class.getName());
/**
- * Map that will contain key as table unique name and value as cache Holder
+ * Guava cache that holds key as table unique name and value as cache Holder
* object
*/
- private Map<String, Cacheable> lruCacheMap;
+ private Cache<String, Cacheable> lruCacheMap;
Review comment:
@ajantha-bhat @akashrn5 ok. I will check those caching libraries and will
raise new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
