akashrn5 commented on a change in pull request #3541:
[CARBONDATA-3636]Timeseries query is not hitting datamap if granularity in
query is given case insensitive
URL: https://github.com/apache/carbondata/pull/3541#discussion_r373319949
##########
File path:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/Utils.scala
##########
@@ -519,4 +521,73 @@ object Utils extends PredicateHelper {
}
}
+ /**
Review comment:
Here better to add a comment, which explains the structure of the expression
tree, first write the expression and better to draw a tree, of ScalaUDFExpr,
children as TimeSeriesFun and Literal , so it will hep to understand the below
logic in a better way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
