xubo245 commented on a change in pull request #3597: [CARBONDATA-3575] Remove 
redundant exception throws
URL: https://github.com/apache/carbondata/pull/3597#discussion_r373506785
 
 

 ##########
 File path: 
core/src/main/java/org/apache/carbondata/core/keygenerator/KeyGenerator.java
 ##########
 @@ -31,18 +31,16 @@
    *
    * @param keys
    * @return byte array
-   * @throws KeyGenException
    */
-  byte[] generateKey(long[] keys) throws KeyGenException;
+  byte[] generateKey(long[] keys);
 
 Review comment:
   Please check all caller, like: 
org.apache.carbondata.core.scan.result.iterator.RawResultIterator#convertRow

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to