jackylk commented on a change in pull request #3538: [CARBONDATA-3637] Optimize
insert into flow
URL: https://github.com/apache/carbondata/pull/3538#discussion_r376191565
##########
File path:
integration/spark-common/src/main/java/org/apache/carbondata/spark/util/Util.java
##########
@@ -76,9 +76,21 @@ public static boolean
isBlockWithoutBlockletInfoExists(List<CarbonInputSplit> sp
} else if
(org.apache.carbondata.core.metadata.datatype.DataTypes.isDecimal(carbonDataType))
{
return DataTypes.createDecimalType();
} else if (carbonDataType ==
org.apache.carbondata.core.metadata.datatype.DataTypes.TIMESTAMP) {
+ if (forGlobalSort) {
Review comment:
Timestamp is not direct dictionary, is this needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
