jackylk commented on a change in pull request #3598: [CARBONDATA-3684] Remove
MDK and cardinality in write path
URL: https://github.com/apache/carbondata/pull/3598#discussion_r377104995
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
##########
@@ -640,15 +377,91 @@ public int getNumberOfSortColumns() {
return numberOfSortColumns;
}
- public int getNumberOfNoDictSortColumns() {
- return numberOfNoDictSortColumns;
+ public int getLastDimensionColOrdinal() {
+ return lastDimensionColOrdinal;
+ }
+
+ public int getNumberOfColumns() {
+ return numberOfColumnsAfterFlatten;
}
- public int getNumberOfDictSortColumns() {
- return this.numberOfSortColumns - this.numberOfNoDictSortColumns;
+ public int getNumberOfDictDimensions() {
+ return numberOfDictDimensions;
}
- public int getLastDimensionColOrdinal() {
- return lastDimensionColOrdinal;
+ public int getNumberOfSimpleDimensions() {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
