akashrn5 commented on a change in pull request #3603: [CARBONDATA-3679]
Optimize local sort performance
URL: https://github.com/apache/carbondata/pull/3603#discussion_r379251181
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/impl/ParallelReadMergeSorterImpl.java
##########
@@ -154,11 +155,13 @@ public void close() {
/**
* Below method will be used to process data to next step
*/
- private boolean processRowToNextStep(SortDataRows sortDataRows,
SortParameters parameters)
+ private boolean processRowToNextStep(SortDataRows[] sortDataRows,
SortParameters parameters)
Review comment:
better to refactor when we have chance, else it will be skipped actually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
