akashrn5 commented on a change in pull request #3612: [CARBONDATA-3694] 
Separate Materialized View command from DataMap command
URL: https://github.com/apache/carbondata/pull/3612#discussion_r378948860
 
 

 ##########
 File path: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapSchema.java
 ##########
 @@ -290,4 +301,71 @@ public boolean isTimeSeries() {
   public void setTimeSeries(boolean timeSeries) {
     isTimeSeries = timeSeries;
   }
+
+  public boolean supportIncrementalBuild() {
+    String prop = getProperties().get(DataMapProperty.FULL_REFRESH);
+    return prop == null || prop.equalsIgnoreCase("false");
+  }
+
+  public String getPropertiesAsString() {
+    String[] properties = getProperties().entrySet().stream()
+        // ignore internal used property
+        .filter(p ->
+            !p.getKey().equalsIgnoreCase(DataMapProperty.DEFERRED_REBUILD) &&
+            !p.getKey().equalsIgnoreCase(DataMapProperty.CHILD_SELECT_QUERY) &&
+            !p.getKey().equalsIgnoreCase(DataMapProperty.QUERY_TYPE) &&
+            !p.getKey().equalsIgnoreCase(DataMapProperty.FULL_REFRESH))
+        .map(p -> "'" + p.getKey() + "'='" + p.getValue() + "'")
+        .sorted()
+        .toArray(String[]::new);
+    return Strings.mkString(properties, ",");
+  }
+
+  public String getTable() {
 
 Review comment:
   i think can be renamed to `getUniqueTableName`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to