jackylk commented on a change in pull request #3592: [Refactory] merge all
spark-related modules into a spark module
URL: https://github.com/apache/carbondata/pull/3592#discussion_r380421058
##########
File path: pom.xml
##########
@@ -531,14 +528,9 @@
<sourceDirectory>${basedir}/geo/src/main/scala</sourceDirectory>
<sourceDirectory>${basedir}/processing/src/main/java</sourceDirectory>
<sourceDirectory>${basedir}/hadoop/src/main/java</sourceDirectory>
-
<sourceDirectory>${basedir}/integration/spark2/src/main/scala</sourceDirectory>
-
<sourceDirectory>${basedir}/integration/spark2/src/main/spark2.3</sourceDirectory>
-
<sourceDirectory>${basedir}/integration/spark2/src/main/java</sourceDirectory>
-
<sourceDirectory>${basedir}/integration/spark-common/src/main/scala</sourceDirectory>
-
<sourceDirectory>${basedir}/integration/spark-common/src/main/java</sourceDirectory>
-
<sourceDirectory>${basedir}/integration/spark-common/src/main/spark2.3</sourceDirectory>
-
<sourceDirectory>${basedir}/integration/spark-common-test/src/main/scala</sourceDirectory>
-
<sourceDirectory>${basedir}/integration/spark-common-test/src/main/java</sourceDirectory>
+
<sourceDirectory>${basedir}/integration/spark/src/main/scala</sourceDirectory>
+
<sourceDirectory>${basedir}/integration/spark/src/main/spark2.3</sourceDirectory>
Review comment:
Can we move this folder into a new module call 'spark2.3adapter' module?
Then IDE can handle the profile more easily
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services