jackylk commented on a change in pull request #3606: [CARBONDATA-3688] Add
compressor name in data file name
URL: https://github.com/apache/carbondata/pull/3606#discussion_r383083186
##########
File path:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/describeTable/TestDescribeTable.scala
##########
@@ -68,15 +68,6 @@ class TestDescribeTable extends QueryTest with
BeforeAndAfterAll {
assert(descPar.exists(_.toString().contains("Partition Parameters:")))
}
- test(testName = "Compressor Type update from carbon properties") {
- sql("drop table if exists b")
- sql(sqlText = "create table b(a int,b string) STORED AS carbondata")
-
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR,
"gzip")
- val result = sql(sqlText = "desc formatted b").collect()
- assert(result.filter(row => row.getString(0).contains("Data File
Compressor")).head.getString
Review comment:
No, this print is not correct. For example, when loading, user set to use
ZSTD compressor, and then set to SNAPPY again after loading, then this command
still prints SNAPPY which is misleading
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
