ajantha-bhat commented on a change in pull request #3636: [CARBONDATA-3719] 
upgraded hive version to 3.1.0
URL: https://github.com/apache/carbondata/pull/3636#discussion_r383084097
 
 

 ##########
 File path: 
integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
 ##########
 @@ -232,38 +230,6 @@ object CarbonReflectionUtils {
     (ctor.newInstance(conArgs: _*), clazz)
   }
 
-  /**
-   * It is a hack to update the carbon input, output format information to 
#HiveSerDe
-   */
-  def updateCarbonSerdeInfo(): Unit = {
-    val currentMirror = scala.reflect.runtime.currentMirror
 
 Review comment:
   I think this was done for presto scenario. Spark writes a carbon table to 
hive metastore. That time serde was not updated. so the read from presto was 
failing. It may not work now. Can check in cluster

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to