ravipesala commented on issue #3637: [CARBONDATA-3721][CARBONDATA-3590] 
Optimize Bucket Table
URL: https://github.com/apache/carbondata/pull/3637#issuecomment-592972205
 
 
   @Zhangshunyu It was a supported feature earlier but it is bad that code got 
removed some time back. Anyway, spark changed the hashing technique on creating 
buckets so we cannot rely on our own hashing anymore. 
   I see a lot of code got copied spark to just get the hashing. it is not 
recommended to do so as in the future if they change it will again break. Even 
they follow industry-standard murmur hash to do the hash. So please use the 
guava library and do the murmur hashing. Please don't copy the code 
unnecessarily from the spark. 
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to