jackylk commented on a change in pull request #3642: [CARBONDATA-3725]fix 
concurrent creation of Materialized Views issue
URL: https://github.com/apache/carbondata/pull/3642#discussion_r386765528
 
 

 ##########
 File path: 
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
 ##########
 @@ -271,24 +277,23 @@ public synchronized void 
unRegisterDataMapCatalog(DataMapSchema dataMapSchema) {
    */
   public synchronized DataMapCatalog getDataMapCatalog(
       DataMapProvider dataMapProvider,
-      String providerName) throws IOException {
+      String providerName,
+      boolean clearCatalogs) throws IOException {
 
 Review comment:
   This is not clear, maybe it is better to add a separate API to clear the 
catalog
   @ajantha-bhat please check once

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to