jackylk commented on a change in pull request #3583: [CARBONDATA-3687] Support writing non-transactional carbondata files through hive URL: https://github.com/apache/carbondata/pull/3583#discussion_r386767350
########## File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/Field.java ########## @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.apache.carbondata.sdk.file; +package org.apache.carbondata.core.metadata.datatype; Review comment: Why move this package? Originally, this class is intended stay in SDK module so that user only uses API in carbondata-sdk module instead of calling functions in carbondata-core module ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
