Zhangshunyu commented on a change in pull request #3637:
[CARBONDATA-3721][CARBONDATA-3590] Optimize Bucket Table
URL: https://github.com/apache/carbondata/pull/3637#discussion_r386817746
##########
File path: processing/pom.xml
##########
@@ -45,6 +45,11 @@
<artifactId>spark-sql_${scala.binary.version}</artifactId>
<version>${spark.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
Review comment:
@jackylk if want to keep correct join result with parquet bucket tables,
need to use same methods to hash the data of each datatype, so the code is
needed.
1. copy the code from spark, but there are about 2,000 lines and if we copy
the code, once spark change them we need to change together, its not a good
choice, more details pls check the conversations above.
2. depend on spark-unsafe jar, we just depend 1 jar of spark and the changes
of diff spark version don't have effect on us since we use it by version
control in pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
