Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724]
Secondary Index enable on partition Table
URL: https://github.com/apache/carbondata/pull/3639#discussion_r387584627
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
##########
@@ -788,7 +788,13 @@ private boolean addBlockBasedOnMinMaxValue(FilterExecuter
filterExecuter, byte[]
byte[][] minValue, boolean[] minMaxFlag, String filePath, int
blockletId) {
BitSet bitSet = null;
if (filterExecuter instanceof ImplicitColumnFilterExecutor) {
- String uniqueBlockPath =
filePath.substring(filePath.lastIndexOf("/Part") + 1);
+ String uniqueBlockPath;
+ if (segmentPropertiesWrapper.getCarbonTable().isHivePartitionTable()) {
Review comment:
Since you only need isHivePartitionTable and tablePath, can get from
DataMapModel and assign to class-level variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
