ajantha-bhat commented on a change in pull request #3653: [CARBONDATA-3665]
Support TimeBased Cache expiration using ExpiringMap
URL: https://github.com/apache/carbondata/pull/3653#discussion_r390865833
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
##########
@@ -257,10 +264,22 @@ public void put(TableBlockIndexUniqueIdentifierWrapper
tableBlockIndexUniqueIden
for (BlockDataMap blockletDataMap : dataMaps) {
blockletDataMap.convertToUnsafeDMStore();
}
+ // get cacheExpirationTime for table from tableProperties
+ String cacheExpirationTime = null;
+ if (null !=
tableBlockIndexUniqueIdentifierWrapper.getCarbonTable().getTableInfo()
Review comment:
When it can be null ? I think null validation is not required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
