jackylk commented on a change in pull request #3653: [CARBONDATA-3665] Support
TimeBased Cache expiration using ExpiringMap
URL: https://github.com/apache/carbondata/pull/3653#discussion_r392246564
##########
File path:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##########
@@ -2406,4 +2406,15 @@ private CarbonCommonConstants() {
public static final String BUCKET_COLUMNS = "bucket_columns";
public static final String BUCKET_NUMBER = "bucket_number";
+ /**
+ * property for table level cache expiration
+ */
+ public static final String CACHE_EXPIRATION_TIME_IN_SECONDS =
"cache_expiration_time_in_seconds";
+
+ /**
+ * default value for table level cache expiration
Review comment:
```suggestion
* By default, the index cache is not expired by time, thus the cache size
is controlled by setting the maximum size (add the property name here)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
