ajantha-bhat commented on a change in pull request #3672: [CRBONDATA-3746]
Support column chunk cache in reader
URL: https://github.com/apache/carbondata/pull/3672#discussion_r394877982
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/block/TableBlockInfo.java
##########
@@ -105,6 +110,14 @@ public int compare(Distributable o1, Distributable o2) {
public TableBlockInfo(String filePath, long blockOffset, String segmentId,
String[] locations, long blockLength, ColumnarFormatVersion version,
String[] deletedDeltaFilePath) {
+ this(null, filePath, blockOffset, segmentId,
Review comment:
Need to remove this constructor ? Because if somebody don't set table id.
Cache logic may go wrong ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
