akashrn5 commented on a change in pull request #3657: [CARBONDATA-3736] Improve
show segment
URL: https://github.com/apache/carbondata/pull/3657#discussion_r395994583
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##########
@@ -38,126 +35,141 @@ import org.apache.carbondata.core.locks.{CarbonLockUtil,
ICarbonLock, LockUsage}
import org.apache.carbondata.core.metadata.{AbsoluteTableIdentifier,
SegmentFileStore}
import org.apache.carbondata.core.metadata.schema.table.CarbonTable
import org.apache.carbondata.core.mutate.CarbonUpdateUtil
-import org.apache.carbondata.core.statusmanager.{FileFormat, SegmentStatus,
SegmentStatusManager}
+import org.apache.carbondata.core.statusmanager.{FileFormat,
LoadMetadataDetails, SegmentStatus, SegmentStatusManager}
import org.apache.carbondata.core.util.path.CarbonTablePath
import org.apache.carbondata.streaming.segment.StreamSegment
object CarbonStore {
private val LOGGER =
LogServiceFactory.getLogService(this.getClass.getCanonicalName)
- def showSegments(
- limit: Option[String],
- tablePath: String,
- showHistory: Boolean): Seq[Row] = {
+ def readSegments(tablePath: String, showHistory: Boolean):
Array[LoadMetadataDetails] = {
val metaFolder = CarbonTablePath.getMetadataPath(tablePath)
- val loadMetadataDetailsArray = if (showHistory) {
+ val allSegments = if (showHistory) {
SegmentStatusManager.readLoadMetadata(metaFolder) ++
SegmentStatusManager.readLoadHistoryMetadata(metaFolder)
} else {
SegmentStatusManager.readLoadMetadata(metaFolder)
}
+ val segments = if (!showHistory) {
+ allSegments.filter(_.getVisibility.equalsIgnoreCase("true"))
+ } else {
+ allSegments
+ }
+ segments
Review comment:
instead of `segments` or `allSegments` , according to method return type, it
would be better if we rename to `segmentsMetadataDetails`, it makes more sense
i think, whats your opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
