ajantha-bhat commented on a change in pull request #3661: [WIP] Support 
materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r399961269
 
 

 ##########
 File path: 
common/src/main/java/org/apache/carbondata/common/exceptions/sql/MalformedIndexCommandException.java
 ##########
 @@ -21,21 +21,21 @@
 import org.apache.carbondata.common.annotations.InterfaceStability;
 
 /**
- * This exception will be thrown when Datamap related SQL statement is invalid
+ * This exception will be thrown when index related SQL statement is invalid
 
 Review comment:
   @niuge01 and @jackylk : As per my understanding. After this PR. There won't 
be datamap word in the code. It is either index or materialized view. But 
**many package names still has datamap** [exmaple CgDatamap, FgDatamap] and 
**files also exist with datamap name**. [Example DataMapStatus, 
DataMapStatusManager] 
   Do we need to completly remove if weare doing this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to