jackylk commented on a change in pull request #3687: [CARBONDATA-3761] Remove
redundant conversion for complex type insert
URL: https://github.com/apache/carbondata/pull/3687#discussion_r403476980
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java
##########
@@ -240,141 +238,137 @@ public boolean getIsColumnDictionary() {
@Override
public void writeByteArray(Object input, DataOutputStream dataOutputStream,
Review comment:
Can you break this function into smaller functions to make it more easy to
understand
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
