akashrn5 commented on a change in pull request #3697: [HOTFIX] Refactored hive
related classes to use constants
URL: https://github.com/apache/carbondata/pull/3697#discussion_r403961085
##########
File path:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonOutputFormat.java
##########
@@ -61,24 +68,25 @@ public void checkOutputSpecs(FileSystem fileSystem,
JobConf jobConf) throws IOEx
public FileSinkOperator.RecordWriter getHiveRecordWriter(JobConf jc, Path
finalOutPath,
Class<? extends Writable> valueClass, boolean isCompressed, Properties
tableProperties,
Progressable progress) throws IOException {
+ ThreadLocalSessionInfo.setConfigurationToCurrentThread(jc);
CarbonLoadModel carbonLoadModel = null;
- String encodedString = jc.get(LOAD_MODEL);
+ // Take carbonLoadModel from container environment if set.
Review comment:
i think here first we should try to get directly from conf, if we dont get
then we can try from systemEnv, it will serve all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
