kevinjmh commented on a change in pull request #3697: [HOTFIX] Refactored hive
related classes to use constants
URL: https://github.com/apache/carbondata/pull/3697#discussion_r405391079
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
##########
@@ -855,7 +855,11 @@ private void loadProperties() {
* Return the store path
*/
public static String getStorePath() {
- return getInstance().getProperty(CarbonCommonConstants.STORE_LOCATION);
+ String storePath =
getInstance().getProperty(CarbonCommonConstants.STORE_LOCATION);
+ if (storePath == null) {
Review comment:
> Internally spark sets the value of spark.warehouse.dir to
hive.metastore.warehouse.dir, so hive.metastore.warehouse.dir is enough here
we can mark this as comment in code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
