kunal642 commented on a change in pull request #3686: [CARBONDATA-3759]Refactor
segmentRefreshInfo and fix cache issue in multiple application scenario
URL: https://github.com/apache/carbondata/pull/3686#discussion_r405532556
##########
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentRefreshInfo.java
##########
@@ -21,12 +21,17 @@
public class SegmentRefreshInfo implements Serializable {
- private Long segmentUpdatedTimestamp;
+ private Long segmentUpdatedTimestamp = 0L;
private Integer countOfFileInSegment;
+ private Long segmentFileTimestamp = 0L;
- public SegmentRefreshInfo(Long segmentUpdatedTimestamp, Integer
countOfFileInSegment) {
- this.segmentUpdatedTimestamp = segmentUpdatedTimestamp;
+ public SegmentRefreshInfo(Long segmentUpdatedTimestamp, Integer
countOfFileInSegment,
+ Long segmentFileTimestamp) {
+ if (segmentUpdatedTimestamp != null) {
Review comment:
@ajantha-bhat We already have a check for segmentFile existance to handle
compatibility.
And incase of multiple drivers the driver which has old information this
code will check the latest timestamp of the file with the updateVo to check
whether any other driver has updated or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
