ajantha-bhat commented on a change in pull request #3701: [CARBONDATA-3770]
Improve partition count star query performance
URL: https://github.com/apache/carbondata/pull/3701#discussion_r407408617
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/CarbonCountStar.scala
##########
@@ -55,34 +67,39 @@ case class CarbonCountStar(
val (job, tableInputFormat) =
createCarbonInputFormat(absoluteTableIdentifier)
CarbonInputFormat.setQuerySegment(job.getConfiguration, carbonTable)
- // get row count
- var rowCount = CarbonUpdateUtil.getRowCount(
- tableInputFormat.getBlockRowCount(
- job,
- carbonTable,
- CarbonFilters.getPartitions(
- Seq.empty,
- sparkSession,
- TableIdentifier(
- carbonTable.getTableName,
- Some(carbonTable.getDatabaseName))).map(_.asJava).orNull, false),
- carbonTable)
+ var totalRowCount: Long = 0
+ if (predicates.nonEmpty) {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
