jackylk commented on a change in pull request #3718: [CARBONDATA-3680]Add NI as 
a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#discussion_r410550755
 
 

 ##########
 File path: 
integration/spark/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
 ##########
 @@ -74,7 +75,13 @@ class CarbonEnv {
 
     sparkSession.udf.register("getTupleId", () => "")
     sparkSession.udf.register("getPositionId", () => "")
-    sparkSession.udf.register("NI", (anyRef: AnyRef) => true)
+    CreateFunctionCommand(None,
 
 Review comment:
   move None to next line and give parameter name for all parameters

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to