jackylk commented on a change in pull request #3714: [CARBONDATA-3773] Skip
Validate partition info in Indexserver count star flow
URL: https://github.com/apache/carbondata/pull/3714#discussion_r410554671
##########
File path: core/src/main/java/org/apache/carbondata/core/index/TableIndex.java
##########
@@ -591,14 +591,14 @@ public void onEvent(Event event, OperationContext
opContext) {
* @throws IOException
*/
public Map<String, Long> getBlockRowCount(List<Segment> allsegments,
- final List<PartitionSpec> partitions, TableIndex defaultIndex)
+ final List<PartitionSpec> partitions, TableIndex defaultIndex, boolean
isIUDFlow)
Review comment:
It is not good idea to add such parameter, which hides the actual behavior
of this function
Can you refactor it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
