jackylk commented on a change in pull request #3717: [HOTFIX]Old store read
compatibility issue for Index handler column
URL: https://github.com/apache/carbondata/pull/3717#discussion_r410557172
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
##########
@@ -605,6 +605,14 @@ public TableSchema fromExternalToWrapperTableSchema(
.setLocalDictColumnsToWrapperSchema(listOfColumns,
externalTableSchema.tableProperties,
externalTableSchema.tableProperties
.get(CarbonCommonConstants.LOCAL_DICTIONARY_ENABLE));
+ String handler =
externalTableSchema.tableProperties.get(CarbonCommonConstants.INDEX_HANDLER);
+ if (handler != null) {
+ for (ColumnSchema columnSchema : listOfColumns) {
+ if (handler.equalsIgnoreCase(columnSchema.getColumnName())) {
Review comment:
Why are you checking column name against handler?
Either of these is not a proper name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
