niuge01 commented on a change in pull request #3692:
URL: https://github.com/apache/carbondata/pull/3692#discussion_r413476515
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/timeseries/TestMVTimeSeriesLoadAndQuery.scala
##########
@@ -230,74 +229,77 @@ class TestMVTimeSeriesLoadAndQuery extends QueryTest with
BeforeAndAfterAll {
checkPlan("mv1", df1)
val df2 = sql("select distinct(timeseries(projectjoindate,'month')) from
maintable")
checkPlan("mv1", df2)
- // TODO: cast expression and group by not allowing to create indexSchema,
check later
+ // TODO: cast expression and group by not allowing to create mv, check
later
// sql(
// "create materialized view mv2 as " +
// "select timeseries(projectjoindate,'month'),cast(floor((projectcode +
1000) / 900) * 900 - 2000 AS INT) from maintable group by
timeseries(projectjoindate,'month'),projectcode")
// val df3 = sql("select
timeseries(projectjoindate,'month'),cast(floor((projectcode + 1000) / 900) *
900 - 2000 AS INT) from maintable group by
timeseries(projectjoindate,'month'),projectcode")
// checkPlan("mv2", df3)
- dropMaterializedView("mv1")
+ dropMV("mv1")
}
test("test mvtimeseries with alias") {
val result = sql("select timeseries(projectjoindate,'month'),projectcode
from maintable group by timeseries(projectjoindate,'month'),projectcode")
- dropMaterializedView("mv1")
+ dropMV("mv1")
sql(
"create materialized view mv1 as " +
"select timeseries(projectjoindate,'month') as t,projectcode as y from
maintable group by timeseries(projectjoindate,'month'),projectcode")
loadData("maintable")
val df1 = sql("select timeseries(projectjoindate,'month') as t,projectcode
as y from maintable group by timeseries(projectjoindate,'month'),projectcode")
checkPlan("mv1", df1)
+ // TODO: fix the base issue of alias with group by
Review comment:
OK, I will check it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
