ajantha-bhat commented on a change in pull request #3717:
URL: https://github.com/apache/carbondata/pull/3717#discussion_r413520184
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
##########
@@ -605,6 +605,14 @@ public TableSchema fromExternalToWrapperTableSchema(
.setLocalDictColumnsToWrapperSchema(listOfColumns,
externalTableSchema.tableProperties,
externalTableSchema.tableProperties
.get(CarbonCommonConstants.LOCAL_DICTIONARY_ENABLE));
+ String handler =
externalTableSchema.tableProperties.get(CarbonCommonConstants.INDEX_HANDLER);
+ if (handler != null) {
+ for (ColumnSchema columnSchema : listOfColumns) {
+ if (handler.equalsIgnoreCase(columnSchema.getColumnName())) {
Review comment:
I strongly agree with @jackylk, we already have many index like SI,
bloom, lucene.
This index handler and isIndex column is confusing.
so we should have something like `spatialIndexHandler` and
`isSpatialIndexColumn` as we use these interface for geo spatial / spatial only
now.
But renaming thrift will again create compatibility issue if somebody
started geospatial already.
@VenuReddy2103 : we can have that renaming change in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
