niuge01 commented on a change in pull request #3727:
URL: https://github.com/apache/carbondata/pull/3727#discussion_r415571503
##########
File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java
##########
@@ -105,10 +89,14 @@ private SchemaProvider getSchemaProvider(String
databaseName) {
if (schemaProvider == null) {
String databaseLocation;
if
(databaseNameUpper.equalsIgnoreCase(CarbonCommonConstants.DATABASE_DEFAULT_NAME))
{
- databaseLocation =
CarbonUtil.checkAndAppendHDFSUrl(this.storeLocation);
+ databaseLocation = CarbonUtil.checkAndAppendHDFSUrl(
+ viewManager.getDatabaseLocation(databaseName)
Review comment:
OK
##########
File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java
##########
@@ -121,70 +109,69 @@ private SchemaProvider getSchemaProvider(String
databaseName) {
return schemaProvider;
}
- public MVSchema getSchema(MVManager viewManager,
- String databaseName, String viewName) throws
IOException {
- SchemaProvider schemaProvider = this.getSchemaProvider(databaseName);
+ public MVSchema getSchema(MVManager viewManager, String databaseName, String
viewName)
+ throws IOException {
+ SchemaProvider schemaProvider = this.getSchemaProvider(viewManager,
databaseName);
if (schemaProvider == null) {
return null;
}
return schemaProvider.retrieveSchema(viewManager, viewName);
}
- List<MVSchema> getSchemas(MVManager viewManager,
- String databaseName, CarbonTable carbonTable)
throws IOException {
- SchemaProvider schemaProvider = this.getSchemaProvider(databaseName);
+ List<MVSchema> getSchemas(MVManager viewManager, String databaseName,
CarbonTable carbonTable)
+ throws IOException {
+ SchemaProvider schemaProvider = this.getSchemaProvider(viewManager,
databaseName);
if (schemaProvider == null) {
return Collections.emptyList();
} else {
return schemaProvider.retrieveSchemas(viewManager, carbonTable);
}
}
- List<MVSchema> getSchemas(MVManager viewManager,
- String databaseName) throws IOException {
- SchemaProvider schemaProvider = this.getSchemaProvider(databaseName);
+ List<MVSchema> getSchemas(MVManager viewManager, String databaseName) throws
IOException {
+ SchemaProvider schemaProvider = this.getSchemaProvider(viewManager,
databaseName);
if (schemaProvider == null) {
return Collections.emptyList();
} else {
return schemaProvider.retrieveAllSchemas(viewManager);
}
}
- void saveSchema(MVManager viewManager, String databaseName,
- MVSchema viewSchema) throws IOException {
- SchemaProvider schemaProvider = this.getSchemaProvider(databaseName);
+ void saveSchema(MVManager viewManager, String databaseName, MVSchema
viewSchema)
+ throws IOException {
+ SchemaProvider schemaProvider = this.getSchemaProvider(viewManager,
databaseName);
if (schemaProvider == null) {
throw new IOException("Database [" + databaseName + "] is not found.");
}
schemaProvider.saveSchema(viewManager, viewSchema);
}
- public void dropSchema(String databaseName, String viewName)
+ public void dropSchema(MVManager viewManager, String databaseName, String
viewName)
throws IOException {
- SchemaProvider schemaProvider = this.getSchemaProvider(databaseName);
+ SchemaProvider schemaProvider = this.getSchemaProvider(viewManager,
databaseName);
if (schemaProvider == null) {
throw new IOException("Materialized view with name " + databaseName +
"." + viewName +
" does not exists in storage");
}
schemaProvider.dropSchema(viewName);
}
- private String getStatusFileName(String databaseName) {
+ private String getStatusFileName(MVManager viewManager, String databaseName)
{
if (databaseName.equalsIgnoreCase("default")) {
- return this.storeLocation +
+ return viewManager.getDatabaseLocation(databaseName) +
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
