Indhumathi27 commented on a change in pull request #3301:
URL: https://github.com/apache/carbondata/pull/3301#discussion_r416474667
##########
File path:
sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
##########
@@ -283,6 +280,96 @@ public static Schema readSchemaInIndexFile(String
indexFilePath) throws IOExcept
return readSchema(indexFilePath, false);
}
+ public static StructField getStructChildren(CarbonTable table, String
columnName) {
+ List<CarbonDimension> list = table.getChildren(columnName);
+ List<StructField> structFields = new ArrayList<StructField>();
+ for (int i = 0; i < list.size(); i++) {
+ CarbonDimension carbonDimension = list.get(i);
Review comment:
Can you extract common code from `getStructChildren` and
`getArrayChildren`methods to new method and reuse
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
