akashrn5 commented on a change in pull request #3738:
URL: https://github.com/apache/carbondata/pull/3738#discussion_r419892047
##########
File path: docs/ddl-of-carbondata.md
##########
@@ -608,12 +607,10 @@ CarbonData DDL statements are documented here,which
includes:
This can be SDK output or C++ SDK output. Refer [SDK Guide](./sdk-guide.md)
and [C++ SDK Guide](./csdk-guide.md).
**Note:**
- 1. Dropping of the external table should not delete the files present in the
location.
+ 1. Dropping of the external table will not delete the files present in the
location.
2. When external table is created on non-transactional table data,
external table will be registered with the schema of carbondata files.
- If multiple files with different schema is present, exception will be
thrown.
- So, If table registered with one schema and files are of different schema,
- suggest to drop the external table and create again to register table with
new schema.
+ If multiple files with different schema is present, exception will be
thrown.
Review comment:
actually if multiple files different schema present, we check if same
column present with different schema, in that case we throw exception, so here
we can be more specific
##########
File path: docs/index-server.md
##########
@@ -82,6 +82,15 @@ the pruned blocklets which would be further used for result
fetching.
**Note:** Multiple JDBC drivers can connect to the index server to use the
cache.
+## Enabling Size based distribution for Legacy stores
+The default round robin based distribution causes unequal distribution of
cache amoung the executors, which can cause any 1 of the executors to be
bloated with too much cache and cause performance degrade.
Review comment:
```suggestion
The default round robin based distribution causes unequal distribution of
cache among the executors, which can cause any one of the executors to be
bloated with too much cache resulting in performance degrade.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
