ajantha-bhat commented on a change in pull request #3740:
URL: https://github.com/apache/carbondata/pull/3740#discussion_r420188382
##########
File path: docs/quick-start-guide.md
##########
@@ -348,10 +341,10 @@ $SPARK_HOME/carbonlib/$CARBON_ASSEMBLY_JAR
<carbon_store_path>
| Parameter | Description
| Example |
| ------------------- |
------------------------------------------------------------ |
---------------------------------------------------------- |
-| CARBON_ASSEMBLY_JAR | CarbonData assembly jar name present in the
`$SPARK_HOME/carbonlib/` folder. |
carbondata_2.xx-x.x.x-SNAPSHOT-shade-hadoop2.7.2.jar |
-| carbon_store_path | This is a parameter to the CarbonThriftServer class.
This a HDFS path where CarbonData files will be kept. Strongly Recommended to
put same as carbon.storelocation parameter of carbon.properties. If not
specified then it takes spark.sql.warehouse.dir path. |
`hdfs://<host_name>:port/user/hive/warehouse/carbon.store` |
+| CARBON_ASSEMBLY_JAR | CarbonData assembly jar name present in the
`$SPARK_HOME/carbonlib/` folder. | apache-carbondata-xx.jar |
+| carbon_store_path | This is a parameter to the CarbonThriftServer class.
This HDFS path where CarbonData files will be kept. Strongly Recommended to put
same as carbon.storelocation parameter of carbon.properties. If not specified
then it takes spark.sql.warehouse.dir path. |
`hdfs://<host_name>:port/user/hive/warehouse/carbon.store` |
Review comment:
Have you tested this ? CarbonThriftServer class doesn't take this
argument anymore. Also it takes S3a parameters argument. Please check the class
and update the same
##########
File path: docs/quick-start-guide.md
##########
@@ -348,10 +341,10 @@ $SPARK_HOME/carbonlib/$CARBON_ASSEMBLY_JAR
<carbon_store_path>
| Parameter | Description
| Example |
| ------------------- |
------------------------------------------------------------ |
---------------------------------------------------------- |
-| CARBON_ASSEMBLY_JAR | CarbonData assembly jar name present in the
`$SPARK_HOME/carbonlib/` folder. |
carbondata_2.xx-x.x.x-SNAPSHOT-shade-hadoop2.7.2.jar |
-| carbon_store_path | This is a parameter to the CarbonThriftServer class.
This a HDFS path where CarbonData files will be kept. Strongly Recommended to
put same as carbon.storelocation parameter of carbon.properties. If not
specified then it takes spark.sql.warehouse.dir path. |
`hdfs://<host_name>:port/user/hive/warehouse/carbon.store` |
+| CARBON_ASSEMBLY_JAR | CarbonData assembly jar name present in the
`$SPARK_HOME/carbonlib/` folder. | apache-carbondata-xx.jar |
+| carbon_store_path | This is a parameter to the CarbonThriftServer class.
This HDFS path where CarbonData files will be kept. Strongly Recommended to put
same as carbon.storelocation parameter of carbon.properties. If not specified
then it takes spark.sql.warehouse.dir path. |
`hdfs://<host_name>:port/user/hive/warehouse/carbon.store` |
Review comment:
Have you tested this ? CarbonThriftServer class doesn't take this
argument anymore. Also it takes S3a parameters argument. Please check the class
and update the same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
