ajantha-bhat commented on a change in pull request #3771:
URL: https://github.com/apache/carbondata/pull/3771#discussion_r435034670



##########
File path: 
core/src/main/java/org/apache/carbondata/core/scan/complextypes/ComplexQueryType.java
##########
@@ -67,4 +67,18 @@ private DimensionColumnPage 
getDecodedDimensionPage(DimensionColumnPage[][] dime
     }
     return dimensionColumnPages[columnIndex][pageNumber];
   }
+
+  /**
+   * Method will copy the block chunk holder data and return the cloned value.
+   * This method is also used by child.
+   */
+  protected byte[] copyBlockDataChunkWithoutClone(DimensionRawColumnChunk[] 
rawColumnChunks,
+      DimensionColumnPage[][] dimensionColumnPages, int rowNumber, int 
pageNumber) {
+    byte[] data =
+        getDecodedDimensionPage(dimensionColumnPages, 
rawColumnChunks[columnIndex], pageNumber)

Review comment:
       I have debugged, cache is already there. the argument of this method, 
`DimensionColumnPage[][] dimensionColumnPages` itself is a cache based on 
column index.
   
   go inside `ComplexQueryType#getDecodedDimensionPage` to see it.
   
   Also observed that only once decodeColumnPage called for that page, reset it 
is using from cache only.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to