kevinjmh opened a new pull request #3804:

    ### Why is this PR needed?
    Currently carbon uses priority queue to sort holders of sorted rows. 
    It first polls a holder from the heap, and adds it back if holder is not 
    This will cause two times heap maintainance. We can reduce half of that. 
    ### What changes were proposed in this PR?
    What will be done when poll item from priority queue is:
   1. remove first item.
   2. move the last item to the position of first item, siftDown the new first 
   In the case in carbon, we can peek(without removing from heap) the first 
item and get a row, 
   and siftDown the holder to a proper position if the holder is not empty.
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
    ### Is any new testcase added?
    - No
    - Yes

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

Reply via email to