VenuReddy2103 commented on a change in pull request #3776:
URL: https://github.com/apache/carbondata/pull/3776#discussion_r450746967



##########
File path: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
##########
@@ -282,10 +296,12 @@ private void commitJobForPartition(JobContext context, 
boolean overwriteSet,
         throw new IOException(e);
       }
     }
-    String segmentFileName = SegmentFileStore.genSegmentFileName(
-        loadModel.getSegmentId(), 
String.valueOf(loadModel.getFactTimeStamp()));
     newMetaEntry.setSegmentFile(segmentFileName + CarbonTablePath.SEGMENT_EXT);
-    newMetaEntry.setIndexSize("" + loadModel.getMetrics().getMergeIndexSize());
+    if (isMergeIndex) {

Review comment:
       loadModel.getMetrics().getMergeIndexSize() is filled in 
MergeIndexEventListene.onEvent() when mergeindex is created. So, can't make it 
else case to line 280.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to