Indhumathi27 commented on a change in pull request #3827:
URL: https://github.com/apache/carbondata/pull/3827#discussion_r451494782
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
##########
@@ -65,7 +65,7 @@
* creates new segment folder and manages the folder through tablestatus file.
* It also generate and writes dictionary data during load only if dictionary
server is configured.
*/
-// TODO Move dictionary generater which is coded in spark to MR framework.
+// TODO Move dictionary generator which is coded in spark to MR framework.
public class CarbonTableOutputFormat extends FileOutputFormat<NullWritable,
ObjectArrayWritable> {
protected static final String LOAD_MODEL =
"mapreduce.carbontable.load.model";
Review comment:
1. Rename UPADTE_TIMESTAMP variable
2. Remove unused OPERATION_CONTEXT
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputFormatUtil.java
##########
@@ -48,7 +48,7 @@
public static <V> CarbonFileInputFormat<V> createCarbonFileInputFormat(
AbsoluteTableIdentifier identifier, Job job) throws IOException {
- CarbonFileInputFormat<V> carbonInputFormat = new
CarbonFileInputFormat<V>();
+ CarbonFileInputFormat<V> carbonInputFormat = new CarbonFileInputFormat<>();
Review comment:
Looks like this method is Unused and LOGGER also
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
##########
@@ -217,16 +217,6 @@
return splits;
}
- /**
Review comment:
Update Line No:105
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java
##########
@@ -259,14 +259,7 @@ public static void setColumnProjection(Configuration
configuration, CarbonProjec
if (projection == null || projection.isEmpty()) {
return;
}
- String[] allColumns = projection.getAllColumns();
- StringBuilder builder = new StringBuilder();
- for (String column : allColumns) {
- builder.append(column).append(",");
- }
- String columnString = builder.toString();
- columnString = columnString.substring(0, columnString.length() - 1);
- configuration.set(COLUMN_PROJECTION, columnString);
+ setColumnProjection(configuration, projection.getAllColumns());
Review comment:
1. Please check line no 190 and fix
2. Remove unused method `setFgIndexPruning`
3. Looks like isFgIndexPruningEnable will always be true. Can check and
remove
4. Line No. 394, can update the method defintion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
