[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3832: [CARBONDATA-3893] [IUD] Fix getting block name in compacted segment with dot for horizontal compaction delta files

[GitBox]

Indhumathi27 commented on a change in pull request #3832:
URL: https://github.com/apache/carbondata/pull/3832#discussion_r451973238



##########
File path: 
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
##########
@@ -450,8 +450,7 @@ public boolean accept(CarbonFile pathName) {
             String fileName = pathName.getName();
             if (fileName.endsWith(CarbonCommonConstants.DELETE_DELTA_FILE_EXT)
                 && pathName.getSize() > 0) {
-              String firstPart = fileName.substring(0, fileName.indexOf('.'));
-              String blkName = firstPart.substring(0, 
firstPart.lastIndexOf("-"));
+              String blkName = fileName.substring(0, 
fileName.lastIndexOf("-"));

Review comment:
       Can you please add a testcase to check num of files after update/delete 
in a compacted segment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org