kunal642 commented on a change in pull request #3822:
URL: https://github.com/apache/carbondata/pull/3822#discussion_r453299220
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
##########
@@ -921,52 +921,55 @@ object CommonUtil {
var i = 0
val fieldTypesLen = fields.length
while (i < fieldTypesLen) {
- if (!row.isNullAt(i)) {
- fields(i).dataType match {
- case StringType =>
- data(i) =
DataTypeUtil.getBytesDataDataTypeForNoDictionaryColumn(row.getString(i),
+ fields(i).dataType match {
Review comment:
It is already handled for other types..Test cases is added
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestGlobalSortDataLoad.scala
##########
@@ -468,6 +470,16 @@ class TestGlobalSortDataLoad extends QueryTest with
BeforeAndAfterEach with Befo
sql("SELECT * FROM carbon_localsort_difftypes ORDER BY shortField"))
}
+ test("test global sort with null values") {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
