VenuReddy2103 commented on a change in pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#discussion_r458023893
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/view/MVManagerInSpark.scala
##########
@@ -48,17 +48,14 @@ class MVManagerInSpark(session: SparkSession) extends
MVManager {
object MVManagerInSpark {
- private val MANAGER_MAP_BY_SESSION =
- new util.HashMap[SparkSession, MVManagerInSpark]()
+ private var viewManager: MVManagerInSpark = null
+ // returns single MVManager instance for all the current sessions.
Review comment:
Probably a MVManagerInSpark instance was maintained per SparkSession to
support multi-tenency. Each user may have an independent and isolated set of
databases/tables/conf etc sharing same sparkcontext. I believe, we still need
this isolation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
