QiangCai commented on a change in pull request #3849:
URL: https://github.com/apache/carbondata/pull/3849#discussion_r459337221
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithDiffTimestampFormat.scala
##########
@@ -122,6 +122,65 @@ class TestLoadDataWithDiffTimestampFormat extends
QueryTest with BeforeAndAfterA
}
+ test("test load data with date and timestamp format set at different
levels") {
+ sql("DROP TABLE IF EXISTS t3")
+ sql(
+ """
+ CREATE TABLE IF NOT EXISTS t3
+ (ID Int, date date, starttime Timestamp, country String,
+ name String, phonetype String, serialname String, salary Int)
+ STORED AS carbondata TBLPROPERTIES('dateformat'='yyyy/MM/dd',
+ 'timestampformat'='yyyy-MM-dd HH:mm')
+ """)
+ sql(
+ s"""
+ LOAD DATA LOCAL INPATH '$resourcesPath/timeStampFormatData1.csv'
into table t3
+ """)
+ sql(
+ s"""
+ LOAD DATA LOCAL INPATH '$resourcesPath/timeStampFormatData2.csv'
into table t3
+ OPTIONS('dateformat' = 'yyyy-MM-dd','timestampformat'='yyyy/MM/dd
HH:mm:ss')
+ """)
+ val sdf = new SimpleDateFormat("yyyy-MM-dd")
+ checkAnswer(
+ sql("SELECT starttime FROM t3 WHERE ID = 1"),
+ Seq(Row(Timestamp.valueOf("2016-07-23 01:01:00")))
+ )
+ checkAnswer(
+ sql("SELECT starttime FROM t3 WHERE ID = 18"),
+ Seq(Row(Timestamp.valueOf("2016-07-25 02:32:02")))
+ )
+ checkAnswer(
+ sql("SELECT date FROM t3 WHERE ID = 1"),
+ Seq(Row(new Date(sdf.parse("2015-07-23").getTime)))
+ )
+ checkAnswer(
+ sql("SELECT date FROM t3 WHERE ID = 18"),
+ Seq(Row(new Date(sdf.parse("2015-07-25").getTime)))
+ )
+ }
+
+ test("test create table with date and timestamp format and check describe
formatted") {
+ sql("DROP TABLE IF EXISTS t3")
+ sql(
+ """
+ CREATE TABLE IF NOT EXISTS t3
+ (ID Int, date date, starttime Timestamp, country String,
+ name String, phonetype String, serialname String, salary Int)
+ STORED AS carbondata TBLPROPERTIES('dateformat'='yyyy/MM/dd',
+ 'timestampformat'='yyyy-MM-dd HH:mm')
+ """)
+ val descTable = sql(s"describe formatted t3").collect
+ descTable.find(_.get(0).toString.contains("Date Format")) match {
+ case Some(row) => assert(row.get(1).toString.contains("yyyy/MM/dd"))
+ case None => assert(false)
+ }
+ descTable.find(_.get(0).toString.contains("Timestamp Format")) match {
+ case Some(row) => assert(row.get(1).toString.contains("yyyy-MM-dd
HH:mm"))
+ case None => assert(false)
+ }
+ }
+
Review comment:
please add more test case for alter table SET and UNSET tblproperties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
