ShreelekhyaG commented on a change in pull request #3774:
URL: https://github.com/apache/carbondata/pull/3774#discussion_r462128423
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/command/SICreationCommand.scala
##########
@@ -210,6 +210,14 @@ private[sql] case class CarbonCreateSecondaryIndexCommand(
.get
}")
}
+ val properties =
carbonTable.getTableInfo.getFactTable.getTableProperties.asScala
+ val spatialProperty = properties.get(CarbonCommonConstants.SPATIAL_INDEX)
+ if (spatialProperty.isDefined) {
+ if (dims.find(x =>
x.getColName.equalsIgnoreCase(spatialProperty.get.trim)).isDefined) {
Review comment:
changed now
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
##########
@@ -266,16 +266,24 @@ case class CarbonPreInsertionCasts(sparkSession:
SparkSession) extends Rule[Logi
relation: LogicalRelation,
child: LogicalPlan): LogicalPlan = {
val carbonDSRelation =
relation.relation.asInstanceOf[CarbonDatasourceHadoopRelation]
- if (carbonDSRelation.carbonRelation.output.size > CarbonCommonConstants
+ val carbonTable = carbonDSRelation.carbonRelation.carbonTable
+ val properties =
carbonTable.getTableInfo.getFactTable.getTableProperties.asScala
+ val spatialProperty = properties.get(CarbonCommonConstants.SPATIAL_INDEX)
+ var expectedOutput = carbonDSRelation.carbonRelation.output
+ // have to remove geo column to support insert with original schema
Review comment:
same reason as above. To support inset without geo column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
