akkio-97 commented on a change in pull request #3773:
URL: https://github.com/apache/carbondata/pull/3773#discussion_r462856914
##########
File path:
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoCarbonVectorizedRecordReader.java
##########
@@ -176,8 +191,16 @@ private void initBatch() {
for (int i = 0; i < queryDimension.size(); i++) {
ProjectionDimension dim = queryDimension.get(i);
if (dim.getDimension().isComplex()) {
+ List<CarbonDimension> childDimensions =
+ dim.getDimension().getListOfChildDimensions();
+ ArrayList<StructField> childFields = new ArrayList<StructField>();
+ for (int ind = 0; ind < childDimensions.size(); ind++) {
+ ColumnSchema childSchema =
childDimensions.get(ind).getColumnSchema();
Review comment:
done
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
##########
@@ -246,7 +241,28 @@ public void decodeAndFillVector(byte[] pageData,
ColumnVectorInfo vectorInfo, Bi
vector = ColumnarVectorWrapperDirectFactory
.getDirectVectorWrapperFactory(vector, vectorInfo.invertedIndex,
nullBits, deletedRows,
true, false);
- fillVector(pageData, vector, vectorDataType, pageDataType, pageSize,
vectorInfo, nullBits);
+ Deque<CarbonColumnVectorImpl> vectorStack = vectorInfo.getVectorStack();
+ // initialize vectorStack if null
+ if (vectorStack == null && vectorInfo.vector.getColumnVector() != null) {
+ vectorStack = new ArrayDeque<CarbonColumnVectorImpl>();
+ vectorStack.push((CarbonColumnVectorImpl)
vectorInfo.vector.getColumnVector());
+ vectorInfo.setVectorStack(vectorStack);
+ }
+ /**
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
