ajantha-bhat commented on a change in pull request #3880:
URL: https://github.com/apache/carbondata/pull/3880#discussion_r466243016
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
##########
@@ -389,14 +389,16 @@ protected FileSplit makeSplit(String segmentId, String
filePath, long start, lon
public void updateLoadMetaDataDetailsToSegments(List<Segment> validSegments,
List<org.apache.carbondata.hadoop.CarbonInputSplit> prunedSplits) {
+ Map<String, Segment> validSegmentsMap = validSegments.stream()
Review comment:
creating a map everytime for query is also overhead when the valid
segments is in thousands, I suggest we can use `SET` for `validSegments` when
it is formed originally instead of 'LIST'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
