ajantha-bhat commented on a change in pull request #3773:
URL: https://github.com/apache/carbondata/pull/3773#discussion_r466309537



##########
File path: 
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java
##########
@@ -102,6 +126,58 @@ public CarbonColumnVectorImpl(int batchSize, DataType 
dataType) {
 
   }
 
+  @Override
+  public CarbonColumnVector getColumnVector() {
+    return null;
+  }
+
+  @Override
+  public List<CarbonColumnVectorImpl> getChildrenVector() {
+    return childrenVector;
+  }
+
+  @Override
+  public void putArrayObject() {
+    return;
+  }
+
+  public void setChildrenVector(ArrayList<CarbonColumnVectorImpl> 
childrenVector) {
+    this.childrenVector = childrenVector;
+  }
+
+  public ArrayList<Integer> getChildrenElements() {
+    return childrenElements;
+  }
+
+  public void setChildrenElements(ArrayList<Integer> childrenElements) {
+    this.childrenElements = childrenElements;
+  }
+
+  public ArrayList<Integer> getChildrenOffset() {
+    return childrenOffset;
+  }
+
+  public void setChildrenOffset(ArrayList<Integer> childrenOffset) {
+    this.childrenOffset = childrenOffset;
+  }
+
+  public void setChildrenElementsAndOffset(byte[] childPageData) {
+    ByteBuffer childInfoBuffer = ByteBuffer.wrap(childPageData);
+    ArrayList<Integer> childElements = new ArrayList<>();
+    ArrayList<Integer> childOffset = new ArrayList<>();

Review comment:
       offset is not required, even for struct type. so, please remove it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to