QiangCai commented on a change in pull request #3874:
URL: https://github.com/apache/carbondata/pull/3874#discussion_r468361486



##########
File path: 
integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java
##########
@@ -259,7 +262,7 @@ private void processResult(List<CarbonIterator<RowBatch>> 
detailQueryResultItera
       CarbonDimension dims = dimensions.get(i);
       if (dims.hasEncoding(Encoding.DICTIONARY)) {
         // dictionary
-        preparedRow[i] = factToIndexDictColumnMapping[dictionaryIndex++];
+        preparedRow[i] = dictionaryValues[dictionaryIndex++];

Review comment:
       how about adding a method which named 
ByteArrayWrapper.getDictionaryKeyByIndex(int index)?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to