ajantha-bhat edited a comment on pull request #3887:
URL: https://github.com/apache/carbondata/pull/3887#issuecomment-678010210


   @marchpure : 
   > Is there a testcase about STRUCT, in which we decode BINARY by BASE64.
   
   Changes are done for presto read (**binary or base 64 decode is needed 
during the write (converter) step**, not the read step), once decode is done 
writer will store it as a byte[], presto/spark  just reads the byte[]
   
   > we shall combine 3 commits into single commit. right?
   
   This doesn't matter, once all review done, I can squash or the committer 
will squash and merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to