akashrn5 commented on a change in pull request #3887:
URL: https://github.com/apache/carbondata/pull/3887#discussion_r476439569
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java
##########
@@ -102,6 +109,57 @@ public CarbonColumnVectorImpl(int batchSize, DataType
dataType) {
}
+ @Override
+ public List<CarbonColumnVector> getChildrenVector() {
+ return childrenVector;
+ }
+
+ public void setChildrenVector(ArrayList<CarbonColumnVector> childrenVector) {
+ this.childrenVector = childrenVector;
+ }
+
+ public ArrayList<Integer> getNumberOfChildrenElementsInEachRow() {
+ return childElementsForEachRow;
+ }
+
+ public void setNumberOfChildrenElementsInEachRow(ArrayList<Integer>
childrenElements) {
+ this.childElementsForEachRow = childrenElements;
+ }
+
+ public void setNumberOfChildrenElementsForArray(byte[] childPageData, int
pageSize) {
+ // for complex array type, go through parent page to get the child
information
+ ByteBuffer childInfoBuffer = ByteBuffer.wrap(childPageData);
+ ArrayList<Integer> childElementsForEachRow = new ArrayList<>();
+ // osset will be an INT size and value will be another INT size, hence 2 *
INT size
Review comment:
yeah, i agree, but its for developer purpose, whoever has write flow
understanding, it will be easy for them to understand, as we have many such
places with very good comments written by @kumarvishal09 and others. I suggest
to add here.!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
