kunal642 commented on a change in pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#discussion_r480289433
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala
##########
@@ -58,6 +58,16 @@ object NodeType extends Enumeration {
*/
class CarbonSecondaryIndexOptimizer(sparkSession: SparkSession) {
+ // to store the sort node per query
+ var sortNodeForPushDown: Sort = _
+
+ // to store the limit literal per query
+ var limitLiteral : Literal = _
+
+ // by default do not push down notNull filter,
+ // but for orderby limit push down, push down notNull filter also. Else we
get wrong results.
+ var pushDownNotNullFilter : Boolean = _
Review comment:
Why not keep these as local variables in transformFilterToJoin and pass
to rewritePlanForSecondaryIndex()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
